-
Notifications
You must be signed in to change notification settings - Fork 2
#48 heart 컴포넌트 #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#48 heart 컴포넌트 #52
The head ref may contain hidden characters: "feature/#48_Heart-\uCEF4\uD3EC\uB10C\uD2B8"
Conversation
- fill props를 통해 컬러를 변경할 수 있게 설정
- 호출 시 onClick이 있으면 컬러 변경 - 없을 경우 클릭 없이 정적 요소로 사용
haksoo0918
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
간결하게 잘 만들어 주셨습니다. 👍
div 만 버튼으로 바꿔 주시면 될 것 같습니다.
- onClick이 있을때는 button 태그와 cursor-pointer - onClick이 없을때는 div태그
crazyupinc-design
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다
승인드립니다
확인되시면 승인 부탁드립니다! |
haksoo0918
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
제가 확인이 늦었네요. 지송합니다.
github 이용이 서툴러서 뭔가 잘못 눌른거 같기도 하고..;;
이슈 번호
close #48
변경 사항 요약
테스트 결과