Feature/#57 auth api #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horororok
requested review from
crazyupinc-design,
haksoo0918,
junghwaYang and
solprime
junghwaYang
approved these changes
Dec 17, 2024
Contributor
junghwaYang
left a comment
junghwaYang
left a comment
There was a problem hiding this comment.
오우..코드 부터 테스트까지 완벽한 것 같습니다!! 👍🏻
@crazyupinc-design 지이님 이거 활용해서 회원가입/로그인 페이지에 연결하면 될 것 같습니다!
crazyupinc-design
approved these changes
Dec 17, 2024
Collaborator
crazyupinc-design
left a comment
crazyupinc-design
left a comment
There was a problem hiding this comment.
빠른 작업 감사합니다!!!!!!!
승인드립니다~
Contributor
|
@horororok 태훈님 해당 pr merge 해주세요~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 번호
close #57
변경 사항 요약
axios 인스턴스를 이용한 로그인/회원가입 api입니다.
회원가입
400error 이미 존재하는 이메일
500error 서버 내부 오류(이메일은 같으나 이름이 같은 경우 발생하는 것으로 보임, 문서에 설명이 없어서 불명확)
기타 에러
로그인
400error 이메일 또는 비밀번호 불일치
500error 서버 내부 오류
기타 에러
테스트
/test/auth
각 버튼 클릭할 경우 코드에 직접 넣어둔 데이터들 입력됨.
코드 수정해서 시험해보면 됩니다.
에러처리까지 구현하였으니, input 값 연결해서 쓰시면 됩니다.
테스트 결과
베이스(develop) 브랜치에 포함되기 위한 코드는 모두 정상적으로 작동이 되어야 합니다.