-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finger tracking in form #3384
base: master
Are you sure you want to change the base?
Finger tracking in form #3384
Conversation
Merge CN1 master
…recording demos on the devices)
…recording demos on the devices)
Thanks! This code won't compile on our servers since it uses Java 8 lambda syntax. The code should be limited to Java 5 syntax for core code. I would also refactor this so the glass pane is a separate class and the API should only be exposed on that class. So we'd have a new class "PointerTracker" through which this API will be installed. It can be in the same package and use package friendly APIs into Form but that way we'd keep the API changes segregated and clear. Does that make sense? |
Thanks for looking at this, but not sure I get how you want the code structure. Can you point to an example I could use for inspiration? |
I'm not sure if there's something similar in the code I can point you to. My goal is to keep the impact on Form.java to a minimum and ideally make it unaware of most of this change. The logic behind this is two fold:
To do that you can introduce a new class e.g. |
Added support for super-imposing images below the pointer (fingers). I cannot test it on the device (can't build for device with locally modified sources) so I hope you'll review the code before accepting.