-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KeyCode on TextArea DoneEvent #3816
Conversation
added the keycode that triggered the done event to the ActionEvent that is sent.
You can't change the signature of the Other than that looks good. If I would nitpick I would revert the change to |
Also notice the compilation error from CI:
|
yes sorry for ActionEvent, i was editing the class from tablet yesterday and i didn't find the revert button for ActionEvent class. Regarding the TextArea, I changed the fireDoneEvent because, looking in the code, the only call was in the InPlaceEditView, so changing them would not have created incompatibility problems. I still updated the class as you asked |
Thanks. Once a method is public in a framework anyone anywhere can rely on that. Changing a public method would mean breaking code you don't know about. For future PRs please try to include a JavaDoc comment for every method otherwise it looks weird in the JavaDoc. |
PR relates to #3814
Added the keycode that triggered the done event to the ActionEvent that is sent.