Update specialization constant to align with the module proposal #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…YCL module proposal. This patch rework the proposal to match the SYCL group direction. This API has been updated, the description is still work-in-progress.
The best way to have specialization constant implementable as a library is to rely on a kernel side handler. This handler can also be extended to handle barrier or other functionalities. Signed-off-by: Victor Lomuller <[email protected]>
…and NTTP. Signed-off-by: Victor Lomuller <[email protected]>
Naghasan
force-pushed
the
spec-constant-nttp
branch
from
6fc1e65
to
cf88f7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the specialization constant extension proposal to align with the module proposal.
This PR introduce a
kernel_handlerwhich is an optional argument to parallel_for functors and allow the user to query the value for spec constants. This could also be reused to implement other library based functionalities.Note: the module proposal does not yet reflect the changes presented here.