Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test functionality #5

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

Igorjan94
Copy link
Contributor

Adds test to current set of tests (problem must be specified)
acedit --add-test -p A -c 847
<input here>
^D
<output here>
^D

@Igorjan94
Copy link
Contributor Author

Hmmmm...
I thought there will be two PR..

@coderick14
Copy link
Owner

Hey. Your code looks great. There are a few minor changes that need to be done. But I'll take care of it. Can you just send the last two commits ( 2478c1d and ae55deb ) in a different PR?

You can send the initial PR from your branch some-more-languages-and-compiler. Once it's merged, you can give a PR for remaining two commits.

Thanks a lot!!

@Igorjan94
Copy link
Contributor Author

PR'd my branch.

It'll be great, if you'll add "change test by number" functionality.

Also I had some problem with installing it from source with python3:

...
File "ACedIt/acedit/install_entry.py", line 13, in run
    from main import supported_sites
ModuleNotFoundError: No module named 'main'

I've also noticed, that 2to3 option is added only to extra dict, though adding it to setup options doesn't resolve this problem..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants