Added flexibility to get.vimfiles.sh #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Charles - I'd like to go the other direction with this file. Instead of having the URL broken out into variables - it would be better just to assign the URL as a string without any variable construction at all. A chat w/ Ryan convinced me that having variables to build up a URL in this context is overkill - even just the repo-owner name like I had before. If you give me a commit that squashes it down to just a single line for assigning the URL variable, I will merge it in. -Jim |
added 2 commits
October 25, 2011 23:24
…eliminate the separate REPO_NAME variable, because its needed elsewhere. Added ability to back up existing .vim, .vimrc and .gvimrc files before creating symbolic links.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jim,
I modified get.vimfiles.sh to use a slightly different argument to "git clone". This allows it to work correctly on systems that have multiple github identities.
Note that you should cherry pick the changes to get.vimfiles.sh. The change to vimrc_settings was just to update my color scheme.
Charles