Skip to content

feat: add new super stream consumer handle #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −9
Open

feat: add new super stream consumer handle #281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ee94c1
feat: add new super stream consumer handle
Oct 24, 2025
25d9473
fix: export on super stream consumer handle
Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions example/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ import { RouteResponse } from "./responses/route_response"
import { StreamStatsResponse } from "./responses/stream_stats_response"
import { SubscribeResponse } from "./responses/subscribe_response"
import { UnsubscribeResponse } from "./responses/unsubscribe_response"
import { SuperStreamConsumer } from "./super_stream_consumer"
import { SuperStreamConsumer, SuperStreamConsumerFunc } from "./super_stream_consumer"
import { MessageKeyExtractorFunction, SuperStreamPublisher } from "./super_stream_publisher"
import { DEFAULT_FRAME_MAX, REQUIRED_MANAGEMENT_VERSION, ResponseCode, sample, wait } from "./util"
import { ConsumerCreditPolicy, CreditRequestWrapper, defaultCreditPolicy } from "./consumer_credit_policy"
Expand Down Expand Up @@ -249,7 +249,7 @@ export class Client {

public async declareSuperStreamConsumer(
{ superStream, offset, consumerRef, creditPolicy }: DeclareSuperStreamConsumerParams,
handle: ConsumerFunc
handle: SuperStreamConsumerFunc
): Promise<SuperStreamConsumer> {
const partitions = await this.queryPartitions({ superStream })
return SuperStreamConsumer.create(handle, {
Expand Down
11 changes: 7 additions & 4 deletions src/super_stream_consumer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
import { Client } from "./client"
import { Consumer, ConsumerFunc } from "./consumer"
import { Consumer } from "./consumer"
import { ConsumerCreditPolicy, defaultCreditPolicy } from "./consumer_credit_policy"
import { Message } from "./publisher"
import { Offset } from "./requests/subscribe_request"

export type SuperStreamConsumerFunc = (msg: Message, consumer?: Consumer) => Promise<void> | void

export class SuperStreamConsumer {
private consumers: Map<string, Consumer> = new Map<string, Consumer>()
public consumerRef: string
Expand All @@ -13,7 +16,7 @@ export class SuperStreamConsumer {
private creditPolicy: ConsumerCreditPolicy

private constructor(
readonly handle: ConsumerFunc,
readonly handle: SuperStreamConsumerFunc,
params: {
superStream: string
locator: Client
Expand Down Expand Up @@ -42,7 +45,7 @@ export class SuperStreamConsumer {
singleActive: true,
creditPolicy: this.creditPolicy,
},
this.handle,
(msg) => this.handle(msg, this.consumers.get(p)),
this
)
this.consumers.set(p, partitionConsumer)
Expand All @@ -52,7 +55,7 @@ export class SuperStreamConsumer {
}

static async create(
handle: ConsumerFunc,
handle: SuperStreamConsumerFunc,
params: {
superStream: string
locator: Client
Expand Down