Skip to content

Fix loading of transient dependency #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
CompuIves wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix loading of transient dependency #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions functions/api/merge-results.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,4 +494,27 @@ describe("mergeResults", () => {
.version,
).toBe("2.0.2");
});

it.only("can resolve an absolute transient dependency and a semver", async () => {
// https://github.com/CompuIves/codesandbox-client/issues/1355
const originalTimeout = jasmine.DEFAULT_TIMEOUT_INTERVAL;
jasmine.DEFAULT_TIMEOUT_INTERVAL = 10000;

const deps = [
await downloadFixture("0x.js", "6.0.9"),
await downloadFixture("ethers", "4.0.28"),
];

jasmine.DEFAULT_TIMEOUT_INTERVAL = originalTimeout;

const merge = mergeResults(deps);
expect(merge.dependencyAliases.uuid).not.toBeFalsy();

expect(merge.contents["/node_modules/uuid/package.json"]).not.toBeFalsy();

expect(
JSON.parse(merge.contents["/node_modules/uuid/package.json"].content)
.version,
).toBe("2.0.1");
});
});