Repository navigation
fix(l10n): unify zh-Hans pronoun and provider/token terms - #7150
Merged
Merged
Conversation
The zh-Hans pack addressed the user as 你 in 43 strings and 您 in 6, mixing both inside TelemetryNoticeBody. It also translated "provider" as 服务商 in 4 strings against 提供商 in 90, and wrote usage tokens as "Token" in 3 strings against "token" in 40. Align the outliers with the dominant forms, and drop two stray spaces after full-width punctuation in the telemetry notices. 令牌 is kept where it means a credential (OAuth/access token). Refs codewhale-hq#6804 Signed-off-by: luochen211 <cuidong111@gmail.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
github-actions
Bot
added
the
contribution-gate
Hmbown
approved these changes
Oct 30, 2026
Hmbown
pushed a commit
that referenced
this pull request
Oct 31, 2026
…urfaces Changelog lines for #7147, #7146, #7156, #7157, #7158, #7152 and #7150, and credit for the contributors across CHANGELOG `### Contributors`, docs/CONTRIBUTORS.md and UNRELEASED_CONTRIBUTORS (adds @luochen211, whose #7150 and #7149 landed). #7149 is a dead-code chore and has no changelog line. Verified: `python3 scripts/check-contributor-credit.py` reports every contributor in the window credited on all three surfaces; `scripts/preflight.sh --check` passes; `sh scripts/sync-changelog.sh` regenerated crates/tui/CHANGELOG.md. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Makes the zh-Hans pack use one form for each of three terms. In every case the outliers move to the form the rest of the pack already uses:
TelemetryNoticeBodymixed both)It also drops two stray spaces after full-width punctuation in
TelemetryNoticeDefaultOnandTelemetryNoticeCompactBody. 令牌 stays wherever it means a credential (OAuth or access token).In total, 9 strings change and no keys or placeholders change. I'm a native Simplified Chinese speaker; this relates to the localization call-to-action in #6804.
Issue
Refs #6804
How I tested it
cargo test -p codewhale-localization --locked:test result: ok. 54 passed; 0 failedChecklist
main