Repository navigation
test: repair three tests broken on main by catalog and context-window changes - #7155
Closed
luochen211 wants to merge 1 commit into
Closed
luochen211 wants to merge 1 commit into
luochen211 wants to merge 1 commit into
Conversation
… changes - Regenerate providers-export.golden.json. 0e3677b pinned MiniMax-M3.1-Flash, kimi-k3.1-pro, kimi-k3.1-pro-highspeed and gpt-6.1-terra in the bundled catalog without updating the golden, so golden_providers_export_matches_registry failed. - status_report_localizes_the_complete_japanese_surface set only active_context_window_source. Since da026a2 the effective source is read from active_context_window, so install the window beside its source, as 5e9cefd did for three sibling fixtures. - test_update_model_compaction_budget kept the window App::new resolved for the default model, so both models were budgeted against it. Clear it with the other pinned inputs so each model resolves its own window. Verified: both TUI tests fail on c96f4ed; after the change `cargo test -p codewhale-tui --lib --locked -- config_policy_status_tests compaction_budget context_window` gives 30 passed, 0 failed, and `cargo test -p codewhale-config --lib --locked route::export` gives 5 passed, 0 failed. cargo fmt --check is clean. Closes codewhale-hq#7154 Signed-off-by: luochen211 <cuidong111@gmail.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
github-actions
Bot
added
the
contribution-gate
Contributor
Author
|
Closing as superseded: 84acb83 fixed the same three tests on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7154
These three tests fail in
Test (ubuntu-latest)on every open PR. This change fixes only the fixtures and the golden file. No production code changes.golden_providers_export_matches_registry:0e3677baddedMiniMax-M3.1-Flash,kimi-k3.1-pro,kimi-k3.1-pro-highspeedandgpt-6.1-terrato the bundled catalog but did not updateproviders-export.golden.json. Regenerated withWRITE_GOLDEN=1 ... write_golden_providers_export_when_requested -- --ignored. The diff adds only those model rows.status_report_localizes_the_complete_japanese_surface: the fixture set onlyactive_context_window_source. Sinceda026a2, the source comes fromactive_context_window. The fixture now installs the window next to its source, the same fix5e9cefdmade to three sibling fixtures.test_update_model_compaction_budget:App::newinstalls a resolved window for the default model, andeffective_budget_route()prefers it, sodeepseek-v4-proand the unknown model were budgeted against the same window. In production,/modelrefreshes the window (commands/groups/core/core.rs). The test assignsapp.modeldirectly, so it now clearsactive_context_windowalong with the other pinned inputs.Verification
c96f4edc5: both TUI tests fail (0 passed; 2 failed).cargo test -p codewhale-tui --lib --locked -- config_policy_status_tests compaction_budget context_window:30 passed; 0 failedcargo test -p codewhale-config --lib --locked route::export:5 passed; 0 failed; 1 ignoredcargo fmt --all -- --check: clean