Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable build on Mac M1 and other arm64+Neon architectures #100

Merged
merged 1 commit into from
May 19, 2022
Merged

Conversation

cskiraly
Copy link
Contributor

@cskiraly cskiraly commented May 18, 2022

These patches enable arm64+Neon builds of Codex

Build and tests pass on:

  • Apple M1 under MacOS (Big Sur 11.6.1)
  • Apple M1 under Ubuntu (20.04.2 ARM64 in a Parallels VM)
  • Rock64 SBC with RK3328 (DietPi)
  • Raspberry Pi 3 B+ with Broadcom BCM2837 (64-bit RasberryOS)

Changes

Signed-off-by: Csaba Kiraly [email protected]

@cskiraly
Copy link
Contributor Author

still draft, waiting for submodule commits to be merged

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #100 (9f90054) into main (15a5713) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
- Coverage   90.69%   90.66%   -0.04%     
==========================================
  Files          46       46              
  Lines        3010     3010              
==========================================
- Hits         2730     2729       -1     
- Misses        280      281       +1     
Flag Coverage Δ
unittests 90.66% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nim-codex/dagger/blockexchange/engine.nim 93.11% <0.00%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15a5713...9f90054. Read the comment docs.

@dryajov
Copy link
Contributor

dryajov commented May 18, 2022

I think this is pulling some changes from https://github.com/status-im/nim-leopard/tree/arm64, which needs to be merged to master first. Other than that great stuff!

- On Mac, -march=native is only supported in newest Clang versions,
better disable it for now.

- Bumping Leopard version to one that support arm64

Signed-off-by: Csaba Kiraly <[email protected]>
@cskiraly
Copy link
Contributor Author

It is now based on main branch of nim-leopard.

@cskiraly cskiraly merged commit aec9a6e into main May 19, 2022
@cskiraly cskiraly deleted the arm64 branch May 19, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants