Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Taiko L2 #483

Merged
merged 19 commits into from
Sep 13, 2023
Merged

Taiko L2 #483

merged 19 commits into from
Sep 13, 2023

Conversation

markspanbroek
Copy link
Member

@markspanbroek markspanbroek commented Jul 13, 2023 •
edited
Loading

Several fixes to allow a codex node to run against the Taiko L2 testnet.

  • Adds CLI parameter to specify a file containing an ethereum private key
  • Adds deployed address of Marketplace contract on Taiko
  • Waits on 1 confirmation for the ERC20 approve() call before doing further calls
  • Adds integration test that can be run with make testTaiko
  • Updates asynctest and ethers to the latest version

@markspanbroek markspanbroek marked this pull request as ready for review July 13, 2023 14:00
emizzle
emizzle previously approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@emizzle emizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, Mark, looks really good! A few minor suggestions, but nothing blocking.

codex/codex.nim Show resolved Hide resolved
codex/codex.nim Show resolved Hide resolved
codex/contracts/market.nim Show resolved Hide resolved
tests/integration/nodes.nim Outdated Show resolved Hide resolved
tests/integration/nodes.nim Outdated Show resolved Hide resolved
dryajov
dryajov previously approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@dryajov dryajov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would apply @emizzle suggestions tho. They should work and are much cleaner.

@markspanbroek markspanbroek dismissed stale reviews from dryajov and emizzle via 1489a4e July 28, 2023 14:33
@markspanbroek
Copy link
Member Author

Seeing some failing tests in testSales after rebasing onto master, could be related to #494

markspanbroek and others added 16 commits September 13, 2023 11:43
@markspanbroek
[docs] fix two client scenario: add missing collateral
8982862
@markspanbroek
[integration] separate step to wait for node to be started
e4e477f
@markspanbroek
[cli] add option to specify ethereum private key
cabca82
@markspanbroek
Remove unused imports
f74caf8
@markspanbroek
Fix warnings
8103f1d
@markspanbroek
[integration] move type definitions to correct place
fb18bfd
@markspanbroek
[integration] wait a bit longer for a node to start in debug mode
755e36e 
When e.g. running against Taiko test net rpc, the node start
takes longer
@markspanbroek
[integration] simplify handling of codex node and client
c2ab190
@markspanbroek
[integration] add Taiko integration test
808a6d0
@markspanbroek
[contracts] await token approval confirmation before next tx
0a89f3b
@markspanbroek
[contracts] deployment address of marketplace on Taiko
868421a
@markspanbroek
[cli] --eth-private-key now takes a file name
7273527 
Instead of supplying the private key on the command line,
expect the private key to be in a file with the correct
permissions.
@markspanbroek
[utils] Fixes undeclared activeChroniclesStream on Windows
550ddb6
@markspanbroek
[build] update nim-ethers to include PR #52
e57248c 
Co-authored-by: Eric Mastro <[email protected]>
@markspanbroek
[cli] Better error messages when reading eth private key
f78f2af 
Co-authored-by: Eric Mastro <[email protected]>
@markspanbroek
[integration] simplify reading of cmd line arguments
ffc9a2d 
Co-authored-by: Eric Mastro <[email protected]>
@markspanbroek markspanbroek merged commit 71cd351 into master Sep 13, 2023
@markspanbroek markspanbroek deleted the taiko-integration branch September 13, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dryajov dryajov dryajov left review comments

@emizzle emizzle emizzle left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markspanbroek @dryajov @emizzle @jessiebroke