Initial support for nimble lock files #496
Conversation
|
Looks good. There will be some conflicts with my PR to update the deps, but I can handle merging the conflicts. That should resolve the build errors you're seeing. |
|
@yyoncho I still have this in my work queue. It's just been bumped as I needed to work on some other things first. |
- Add parallel ci-lock.yml - In order to sync the lock file do the following: ``` bash nimble lock --developFile=nimble-update-lock.develop ``` Note that --developFile support for lock is part of this PR nim-lang/nimble#1125 to be merged. If it is not merged, then you can rename nimble-update-lock.develop to nimble.develop and `nimble lock` will work just fine. - I have used different `nim` version for the lock file because current `nim` does not have the proper nimble structure. I can bump the version in NBS if you want. I have also changed the versions of some of the packages in `vendor` folder to pass nimble version checks merge in lost change from yyoncho for nimble support only build linux for nimble bump to match NBS fix compiles check fix ci-lock fix ci-lock
|
@dryajov mind reviewing this? It'd be nice to get Nimble running aside NBS. |
|
I'm killing this as we've sort of embraced nimbus-build-system, so our lock files are the commit versions in the |
|
Keep in mind that the plan is still to migrate to nimble and lockfiles, once we migrate to nim 2.0 |
Note that --developFile support for lock is part of this PR nim-lang/nimble#1125 to be merged. If it is not merged, then you can rename nimble-update-lock.develop to nimble.develop and
nimble lockwill work just fine.nimversion for the lock file because currentnimdoes not have the proper nimble structure. I can bump the version in NBS if you want. I have also changed the versions of some of the packages invendorfolder to pass nimble version checks