Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug/extra logging #509

Merged
merged 11 commits into from
Aug 22, 2023
Merged

Debug/extra logging #509

merged 11 commits into from
Aug 22, 2023

Conversation

benbierens
Copy link
Contributor

No description provided.

@benbierens benbierens marked this pull request as ready for review August 22, 2023 06:29
emizzle
emizzle approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@emizzle emizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

Would it not be better to store the BlockReq.startTime as a MonoTime instead of int64 (for operations such as - which is used later on)?

@benbierens benbierens merged commit f10c3f3 into master Aug 22, 2023
6 checks passed
@benbierens benbierens deleted the debug/extra-logging branch August 22, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emizzle emizzle emizzle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benbierens @emizzle