fix: load slots on sales module start #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emizzle
previously approved these changes
Aug 14, 2023
tests/codex/sales/testsales.nim
Outdated
| return data0.requestId == data1.requestId and | ||
| data0.request == data1.request | ||
|
|
||
| check eventuallyCheck sales.agents.len == 2 |
There was a problem hiding this comment.
I think we can use eventually (instead of eventuallyCheck) from asynctest, no?
There was a problem hiding this comment.
I saw your message in Discord, make sense 👍
There was a problem hiding this comment.
Hmm, it seems there are some differences between eventuallyCheck and eventually. 😳 The tests in this file that still use eventuallyCheck started to fail when moved to eventually. 😳
I will merge it in its current form, and once we decide to make the full switch in the codebase, we should take a look at this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #294
Closes #505