Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(openapi): update the openapi spec for the manifest object #972

Merged
merged 4 commits into from
Nov 15, 2024

Conversation

2-towns
Copy link
Contributor

@2-towns 2-towns commented Oct 25, 2024

No description provided.

Copy link
Member

@gmega gmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benbierens
Copy link
Contributor

The newly added manifest fields (filename, etc) seem to some times return null, and crashing deserializers generated from the openAPI yaml. Can we fix this? should the new fields be optional? or have default empty-string values?

@gmega gmega added this pull request to the merge queue Nov 15, 2024
Merged via the queue into master with commit 9b7f3f4 Nov 15, 2024
13 checks passed
@gmega gmega deleted the chore/replace-roothash-by-treecid-for-manifest branch November 15, 2024 14:44
veaceslavdoina pushed a commit that referenced this pull request Nov 26, 2024
* Update the manifest openapi spec

* Make metadata nullable

Signed-off-by: Arnaud <[email protected]>

---------

Signed-off-by: Arnaud <[email protected]>
Co-authored-by: Giuliano Mega <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants