-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ETH_PRIVATE_KEY to Docker entrypoint #982
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emizzle
reviewed
Nov 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we maybe add a depreciation warning of PRIV_KEY is used?
Signed-off-by: Slava <[email protected]>
Added, thanks
|
emizzle
approved these changes
Nov 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!!
veaceslavdoina
added a commit
that referenced
this pull request
Nov 4, 2024
* Add ETH_PRIVATE_KEY to Docker entrypoint * Add deprecation warning for PRIV_KEY variable Signed-off-by: Slava <[email protected]> --------- Signed-off-by: Slava <[email protected]>
veaceslavdoina
added a commit
to codex-storage/codex-docs
that referenced
this pull request
Nov 4, 2024
veaceslavdoina
added a commit
to codex-storage/codex-docs
that referenced
this pull request
Nov 4, 2024
veaceslavdoina
added a commit
to codex-storage/codex-testnet-starter
that referenced
this pull request
Nov 4, 2024
veaceslavdoina
added a commit
to codex-storage/codex-testnet-starter
that referenced
this pull request
Nov 4, 2024
veaceslavdoina
added a commit
to codex-storage/cs-codex-dist-tests
that referenced
this pull request
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick PR to add
ETH_PRIVATE_KEY
to the Docker entrypoint for variables names consistency.During transition period we can use both,
PRIV_KEY
andETH_PRIVATE_KEY
, to the pass Ethereum private key.After we will change all the code to use new variable, the old one will be removed.