Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ETH_PRIVATE_KEY to Docker entrypoint #982

Merged
merged 2 commits into from
Nov 3, 2024

Conversation

veaceslavdoina
Copy link
Contributor

This is a quick PR to add ETH_PRIVATE_KEY to the Docker entrypoint for variables names consistency.

During transition period we can use both, PRIV_KEY and ETH_PRIVATE_KEY, to the pass Ethereum private key.

After we will change all the code to use new variable, the old one will be removed.

Copy link
Contributor

@emizzle emizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe add a depreciation warning of PRIV_KEY is used?

@veaceslavdoina
Copy link
Contributor Author

Added, thanks

PRIV_KEY variable is deprecated and will be removed in the next releases, please use ETH_PRIVATE_KEY instead!
Private key set

Copy link
Contributor

@emizzle emizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@veaceslavdoina veaceslavdoina added this pull request to the merge queue Nov 3, 2024
Merged via the queue into master with commit 9645918 Nov 3, 2024
11 checks passed
@veaceslavdoina veaceslavdoina deleted the feat/update-docker-entrypoint branch November 3, 2024 09:15
veaceslavdoina added a commit that referenced this pull request Nov 4, 2024
* Add ETH_PRIVATE_KEY to Docker entrypoint

* Add deprecation warning for PRIV_KEY variable

Signed-off-by: Slava <[email protected]>

---------

Signed-off-by: Slava <[email protected]>
veaceslavdoina added a commit to codex-storage/codex-docs that referenced this pull request Nov 4, 2024
veaceslavdoina added a commit to codex-storage/codex-testnet-starter that referenced this pull request Nov 4, 2024
veaceslavdoina added a commit to codex-storage/codex-testnet-starter that referenced this pull request Nov 4, 2024
veaceslavdoina added a commit to codex-storage/cs-codex-dist-tests that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants