Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nd Fenwick tree(BIT) #495

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

AbdelrahmanKhaledd
Copy link

I added BIT-2D issue #377
i will add descriptions to code for doc.
i have a problem , i can't import the BIT2D from test files after i added BIT2d allready in binary_trees.py ,despite reinstalling the library after editing.

@czgdp1807
Copy link
Member

czgdp1807 commented Mar 5, 2022

Is it possible to generalise BIT further to n dimensions? You might need to brainstorm to figure out the implementation.

@AbdelrahmanKhaledd
Copy link
Author

AbdelrahmanKhaledd commented Mar 5, 2022

Alright , i will read about it ant try ,but the main problem as i said new classes doesn't included in the library so i can't make tests, is there any place i can discuss my problem?

@czgdp1807
Copy link
Member

You have to include your class in __all__ lists at the correct places for accessing it via imports. In your editor look where, BinaryIndexedTree is mentioned in the project. That should help.

@AbdelrahmanKhaledd
Copy link
Author

AbdelrahmanKhaledd commented Mar 6, 2022

I finished 2d version , now i can add n dimensions version after thinking about its implementation.
shall i make a new pull requrst for it or just rename this one ?

@czgdp1807
Copy link
Member

Do it in this PR.

@AbdelrahmanKhaledd
Copy link
Author

I added it and make tests and everything alrought .
please, review code.

@AbdelrahmanKhaledd
Copy link
Author

Remove 2d one and leave general one if you want.

@czgdp1807
Copy link
Member

The structure looks good. I will review it on Sunday or next Sunday most probably. Feel free to work on other things meanwhile.

@AbdelrahmanKhaledd AbdelrahmanKhaledd changed the title 2D Fenwick tree(BIT) Nd Fenwick tree(BIT) Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants