-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Suffix Tree implementation using Ukkonen algorithm #524
base: main
Are you sure you want to change the base?
Conversation
I would recommend to always shift to a new branch (other than |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. I have left some reviews. Please address them.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #524 +/- ##
=============================================
+ Coverage 98.558% 98.603% +0.045%
=============================================
Files 32 33 +1
Lines 4092 4226 +134
=============================================
+ Hits 4033 4167 +134
Misses 59 59
|
See, https://app.codecov.io/gh/codezonediitj/pydatastructs/pull/524/blob/pydatastructs/strings/suffix_tree.py. There are lots of lines (see the red ones) which aren't tested. Also add pydatastructs/pydatastructs/utils/tests/test_code_quality.py Lines 151 to 177 in 2482adb
|
I followed all the requested changes and added more tests such that the testing covers all the methods and sub-cases. I would be grateful if you could tell me if I can polish the classes in any other way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. Sorry for the later review. Mostly related to documentation.
I combined the |
References to other Issues or PRs or Relevant literature
Brief description of what is fixed or changed
Added suffix tree class
Other comments
May be considered as GSoC 23 work sample