Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CPP version of bubble sort #540

Merged
merged 4 commits into from
Jul 11, 2023
Merged

Conversation

sak-codes
Copy link
Contributor

References to other Issues or PRs or Relevant literature

Brief description of what is fixed or changed

Other comments

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #540 (d015620) into main (0dabe35) will increase coverage by 0.001%.
The diff coverage is 100.000%.

Additional details and impacted files
@@              Coverage Diff              @@
##              main      #540       +/-   ##
=============================================
+ Coverage   97.594%   97.595%   +0.001%     
=============================================
  Files           34        34               
  Lines         4281      4283        +2     
=============================================
+ Hits          4178      4180        +2     
  Misses         103       103               
Impacted Files Coverage Δ
pydatastructs/linear_data_structures/algorithms.py 99.783% <100.000%> (+<0.001%) ⬆️

Impacted file tree graph

Copy link
Member

@czgdp1807 czgdp1807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@czgdp1807
Copy link
Member

When doing benchmarks, the CI on ubuntu goes out of memory and seems like the operation gets cancelled.

@czgdp1807
Copy link
Member

Or I forgot, bubble sort is O(n^2), so it is supposed to be ~4 times slower when on size 4000 so probably CI times out.

@czgdp1807 czgdp1807 marked this pull request as ready for review July 11, 2023 19:40
@czgdp1807 czgdp1807 enabled auto-merge (squash) July 11, 2023 19:40
@czgdp1807 czgdp1807 merged commit 674fc62 into codezonediitj:main Jul 11, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants