Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting code for c++ backend of trees #551

Closed
wants to merge 3 commits into from

Conversation

Kishan-Ved
Copy link
Contributor

References to other Issues or PRs or Relevant literature

Starting code for #550. This is more like a template.

Brief description of what is fixed or changed

This is some starting code for the trees backend. Honestly, some of this was written by ChatGPT, although I have understood and ensured that most of it is correct and necessary. Please check this and let me know if it is correct, so I can proceed with this. Also, please let me know what part has to be included in header file etc.

@Kishan-Ved
Copy link
Contributor Author

This might not seem like a lot of code addition, but I prefer making small PRs and getting code verified atleast at the start.

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.552%. Comparing base (ec0b015) to head (cf62fc5).
Report is 1 commits behind head on main.

❗ Current head cf62fc5 differs from pull request most recent head 8ec0296. Consider uploading reports for the commit 8ec0296 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #551   +/-   ##
=========================================
  Coverage   97.552%   97.552%           
=========================================
  Files           34        34           
  Lines         4331      4331           
=========================================
  Hits          4225      4225           
  Misses         106       106           

Impacted file tree graph

@Kishan-Ved
Copy link
Contributor Author

Gentle Reminder, please check this.

Copy link
Member

@czgdp1807 czgdp1807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please continue working on this.

@czgdp1807
Copy link
Member

Looks duplicate of #555. Closing this in favour of #555.

@czgdp1807 czgdp1807 closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants