Skip to content

data loss fix #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

data loss fix #909

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions app/src/main/java/org/gnucash/android/ui/account/AccountFormFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@

package org.gnucash.android.ui.account;

import static android.content.Context.MODE_PRIVATE;

import android.app.Activity;
import android.content.Context;
import android.content.Intent;
Expand Down Expand Up @@ -358,6 +360,47 @@ public void onActivityCreated(Bundle savedInstanceState) {

}

private SharedPreferences spGen;

private boolean isSubmit;

@Override
public void onPause() {
super.onPause();
SharedPreferences.Editor spGenEditor = spGen.edit();
if (isSubmit) {
spGenEditor.putString("editName", "");
spGenEditor.putLong("editCurrency", Integer.MAX_VALUE);
spGenEditor.putString("editDesc", "");
spGenEditor.putBoolean("editPlaceholder", false);
spGenEditor.putInt("editColor", Account.DEFAULT_COLOR);
} else {
spGenEditor.putString("editName", getEnteredName());
spGenEditor.putLong("editCurrency", mCurrencySpinner.getSelectedItemId());
spGenEditor.putString("editDesc", mDescriptionEditText.getText().toString());
spGenEditor.putBoolean("editPlaceholder", mPlaceholderCheckBox.isChecked());
spGenEditor.putInt("editColor", mSelectedColor);
}
spGenEditor.commit();
}

@Override
public void onResume() {
super.onResume();
spGen = getActivity().getSharedPreferences("AccountFormFragment", MODE_PRIVATE);
mNameEditText.setText(spGen.getString("editName", ""));
int currency = (int) (long) spGen.getLong("editCurrency", Integer.MAX_VALUE);
if(currency == Integer.MAX_VALUE){
setSelectedCurrency(Money.DEFAULT_CURRENCY_CODE);
}else{
mCurrencySpinner.setSelection(currency);
}
mDescriptionEditText.setText(spGen.getString("editDesc", ""));
mPlaceholderCheckBox.setChecked(spGen.getBoolean("editPlaceholder", false));
mSelectedColor = spGen.getInt("editColor", Account.DEFAULT_COLOR);
isSubmit = false;
}

/**
* Initialize view with the properties of <code>account</code>.
* This is applicable when editing an account
Expand Down Expand Up @@ -825,6 +868,7 @@ private void saveAccount() {
}
}
accountsToUpdate.add(mAccount);
isSubmit = true;

// bulk update, will not update transactions
mAccountsDbAdapter.bulkAddRecords(accountsToUpdate, DatabaseAdapter.UpdateMethod.update);
Expand Down