feat: add tests (wip) #143
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These use plenary's busted-like testing framework As such, they require that plenary is installed to run.
|
@amirbilu is this something you're willing to pursue, or is it not worth putting my effort into? |
This clarifies usage of the tests directory and plenary/busted's interface
`None` should be the special value `NONE`
replace with a TODO comment
if not running from the root
this commit includes tests for str_to_lines and lines_to_str It include `pending` tests for the remaining utils
previously it included the system-installed module in completions. We want the local module.
This method doesn't work right.
|
Please note that the current goal of the implemented tests is not to ensure that methods work right (as I've discovered and documented several bugs), but to match the current state of the codebase. This way, when a change is made, it can be quickly tested to ensure that it doesn't break anything else. |
this was a copy paste error
note: these are all wrong because the /tests directory isn't under /lua
this is hard one to test, since it's time related
|
@aarondill this is indeed interesting |
|
I haven't had the opportunity to work on this recently due to real life things. I'll continue to work on this when I can, but I would appreciate contributions if you'd like to accelerate the process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These use plenary's busted-like testing framework
As such, they require that plenary is installed to run.
Note: this is not a dependency for normal runtime.
Should I add a CI check that requires all tests are passing?