Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow utils.debounce to accept nil arguments #164

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow utils.debounce to accept nil arguments #164

wants to merge 2 commits into from

Conversation

aarondill
Copy link
Contributor

@aarondill aarondill commented Mar 25, 2024 •
edited
Loading

part 1 of #141

this allows

local f = utils.debounce(function(...) print(...) end)
f(1, nil, 9, nil, nil) -- "1 nil 9 nil nil"
--- previously would've output "1" (undefined behavior)

@aarondill aarondill mentioned this pull request Mar 25, 2024
Closed
@aarondill @amirbilu
fix: allow nil arguments to debounce function
2c8ce1f 
this allows
```lua
local f = utils.debounce(function(...) print(...) end)
f(1, nil, 9, nil, nil) -- "1 nil 9 nil nil"
--- previously would've output "1" (undefined behavior)
```
@aarondill @amirbilu
fix: table.pack may not be defined
12cd69e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amirbilu amirbilu Awaiting requested review from amirbilu amirbilu is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@aarondill