Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read lines #168

Merged
merged 2 commits into from
Apr 1, 2024
Merged

read lines #168

merged 2 commits into from
Apr 1, 2024

Conversation

amirbilu
Copy link
Contributor

No description provided.

@aarondill
Copy link
Contributor

aarondill commented Mar 30, 2024

I wonder if the OS is buffering the input, causing the line to get split between data packets. that would certainly explain the issue.
Whether this is the original source of #167 or not, if it doesn't cause any additional problems, it's probably a good safe guard to have in place.

@amirbilu
Copy link
Contributor Author

amirbilu commented Apr 1, 2024

@aarondill I kind of knew this is an issue, but left it to future releases since it never was an issue on my machine

@amirbilu amirbilu merged commit ea657a8 into master Apr 1, 2024
2 of 3 checks passed
@amirbilu amirbilu deleted the read_lines branch April 1, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants