Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle errors in finding binary path #82

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Handle errors in finding binary path #82

wants to merge 4 commits into from

Commits on Jan 12, 2024

  1. Handle errors in finding binary path 

    This avoids constant nil errors (fixes codota#77), and quits early if the binary can't be found.
Notifications can easily be added in future commits if so desired to warn the user about what is wrong.
    @aarondill
    aarondill committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    f89f5d7 View commit details
    Browse the repository at this point in the history

  2. clear self.std* when closing 

    This ensures we don't write to an empty pipe.
    @aarondill
    aarondill committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    184bf75 View commit details
    Browse the repository at this point in the history

  3. add warnings in case the binary can't be found (not installed)

    @aarondill
    aarondill committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    a9bf829 View commit details
    Browse the repository at this point in the history

  4. move *up* arch check to ensure that unsupported arches get aborted ea… 

    …rly.

This avoids notifying when the machine is unsupported.
This is prefered behavior by *at least* @vendion
    @aarondill
    aarondill committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    c132306 View commit details
    Browse the repository at this point in the history