Skip to content

[1] Simplify postback handler signatures #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Nov 22, 2023
Merged

[1] Simplify postback handler signatures #372

merged 25 commits into from
Nov 22, 2023

Conversation

@MrOrz
Copy link
Member

@MrOrz MrOrz commented Nov 12, 2023 •
edited
Loading

refactor(context): typing postback action

  • Default as string
  • Enable different type of postback action
  • Simplify handlePostback() argument
  • Update all handlers called by handlePostback()

MrOrz added 18 commits October 19, 2023 02:05
@MrOrz
refactor(context): typing postback action
cbd4064 
- Default as string
- Enable different type of postback action
- Simplify handlePostback() argument with SDK types
@MrOrz
fix: simple handler type
fb8968e
@MrOrz
fix: remove input from postback handler
b071d64
@MrOrz
fix: narrow down choosingArticle input source
65f406d
@MrOrz
refactor(types): define postback handler type
a72821d 
- Should be simpler than ChatbotStateHandler, easier to call
@MrOrz
refactor(webhook): type defaultState
d6718d6
@MrOrz
refactor(webhook): type tutorial
6c1af7a
@MrOrz
refactor(webhook): apply simpler postback handler signatures
2433f47
@MrOrz
refactor(webhook): apply ChatbotPostbackHandler to askingArticleSourc…
7b41e99 
…e and askingArticleSubmissionConsent
@MrOrz
docs(chatbotState): document fields in new postback handlers
42ec52b
@MrOrz
fix(webhook): fix handlePostback invocations
9d74cea
@MrOrz
fix(webhook): fix askingArticleSource test
5b57717
@MrOrz
refactor(webhook): remove unused imports from tutorial
771293b
@MrOrz
fix(webhook): allow tutorials to open new sessions and call as postba…
6d9d49e 
…ck handlers
@MrOrz
fix(types): restore ChatbotEvent to original type
fa5de52 
- We will remove this entirely when we refactor other text-based handlers
@MrOrz
fix(webhook): fix processMedia signature and invocation of choosingAr…
a3b6a12 
…ticle
@MrOrz
fix(webhook): type for initState
7b83d4d
@MrOrz
fix(handlers): fix test for askingArticleSubmissionConsent
dcb8e30
@MrOrz Graphite App
Copy link
Member Author

MrOrz commented Nov 12, 2023 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@MrOrz MrOrz mentioned this pull request Nov 12, 2023
Merged
@coveralls
Copy link

coveralls commented Nov 12, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6841960699

  • 55 of 57 (96.49%) changed or added relevant lines in 12 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 89.786%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/webhook/index.ts 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/webhook/index.ts 1 50.39%
Totals Coverage Status
Change from base Build 6564802716: -0.2%
Covered Lines: 980
Relevant Lines: 1053
💛 - Coveralls

@MrOrz MrOrz mentioned this pull request Nov 12, 2023
Merged
@MrOrz MrOrz changed the title Simplify postback handler signatures [1] Simplify postback handler signatures Nov 12, 2023
@MrOrz MrOrz marked this pull request as ready for review November 12, 2023 17:54
@MrOrz MrOrz requested review from bil4444, nonumpa and yhsiang November 12, 2023 17:54
This was referenced Nov 19, 2023
Merged
Draft
@MrOrz Graphite App
Copy link
Member Author

MrOrz commented Nov 22, 2023 •
edited
Loading

Merge activity

  • Nov 22, 8:01 AM: @MrOrz started a stack merge that includes this pull request via Graphite.
  • Nov 22, 8:01 AM: @MrOrz merged this pull request with Graphite.

@MrOrz MrOrz merged commit 020ce97 into master Nov 22, 2023
@MrOrz MrOrz deleted the revamp-postback-handlers branch November 22, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bil4444 bil4444 bil4444 approved these changes

@nonumpa nonumpa Awaiting requested review from nonumpa

@yhsiang yhsiang Awaiting requested review from yhsiang

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MrOrz @coveralls @bil4444