-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor#209 인증 도메인 구조 변경 #212
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 엔티티의 필드 타입에 맞게 Id 값의 타입은 Reference Type 사용 - 시간 또는 카운트 숫자의 데이터 경우 성능을 고려해서 Primitive Type 사용
- 도메인별로 픽스처 구분
- 엔티티의 필드 타입에 맞게 Id 값의 타입은 Reference Type 사용 - 시간 또는 카운트 숫자의 데이터 경우 성능을 고려해서 Primitive Type 사용
- 도메인별로 픽스처 구분
- VO 와 Dto 로 분리
- 엔티티의 필드 타입에 맞게 Id 값의 타입은 Reference Type 사용 - 시간 또는 카운트 숫자의 데이터 경우 성능을 고려해서 Primitive Type 사용
1o18z
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈번호
close: #209
작업 내용 설명
리뷰어에게 한마디