Feat/#30 유저 프로필 수정 기능 구현 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yumyeonghan
requested changes
Oct 24, 2023
| @@ -4,5 +4,15 @@ public enum Keyword { | |||
| COOK, | |||
| GAME, | |||
| EXERCISE, | |||
| ; | |||
|
|
|||
| public static boolean isValidKeyword(String keyword) { | |||
There was a problem hiding this comment.
Enum에서 제공하는 Keyword.valueOf() 메서드 사용하는게 더 좋아보여요!
| } | ||
| } | ||
|
|
||
| private void validateInterests(List<Keyword> interests) { |
There was a problem hiding this comment.
서비스 레이어에서 말고,
DTO 객체에서 입력값에 대한 검증 로직을 추가하는게 좋아보입니다!
| import jakarta.validation.constraints.NotBlank; | ||
| import java.util.List; | ||
|
|
||
| public record UpdateProfileRequest(@NotBlank String nickname, List<Keyword> interests) { |
Comment on lines
59
to
64
| if (nickname != null) { | ||
| user.getProfile().updateNickname(nickname); | ||
| } | ||
| if (interests != null && !interests.isEmpty()) { | ||
| interestService.updateInterests(userId, interests); | ||
| } |
There was a problem hiding this comment.
입력 값에 대한 검증 로직은 dto에 추가해 주세요
| @@ -29,4 +34,18 @@ public ResponseEntity<MyProfileResponse> findMyProfile(@Login AuthInfo authInfo) | |||
| return ResponseEntity.ok(userService.findMyProfile(authInfo.userId())); | |||
| } | |||
|
|
|||
| @PatchMapping("/me/profile-image") | |||
| public ResponseEntity<Void> updateProfileImage(@Login AuthInfo authInfo, | |||
| @RequestParam String profileImageUrl) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈번호
close: #30
작업 내용 설명
리뷰어에게 한마디