Reactive Power: Make use of the correct symbol and not description#198
Open
dietmarw-se wants to merge 1 commit intocognitedata:mainfrom
Open
Reactive Power: Make use of the correct symbol and not description#198dietmarw-se wants to merge 1 commit intocognitedata:mainfrom
dietmarw-se wants to merge 1 commit intocognitedata:mainfrom
Conversation
The proper unit for reactive power is "var" already standardised in 1930 by the EEC (see also https://en.wikipedia.org/wiki/Volt-ampere#Reactive) The QUDT points kind of to the correct unit but misinterprets the symbol in https://qudt.org/vocab/unit/VAR from its own source (https://cdd.iec.ch/cdd/iec62720/iec62720.nsf/Units/0112-2---62720%23UAB023) To emphasis, the equivalent for "Apparent Power" is configured correctly to "VA" from https://qudt.org/vocab/unit/VA and https://cdd.iec.ch/cdd/iec62720/iec62720.nsf/Units/0112-2---62720%23UAA298 , respectively
evertoncolling
approved these changes
Feb 26, 2026
Collaborator
evertoncolling
left a comment
evertoncolling
left a comment
There was a problem hiding this comment.
We only treat unit.symbol as mutable metadata, so this is a safe and reasonable update. Thanks for the contribution!
It should be visible in CDF after we issue another release of the catalog.
evertoncolling
added
the
waiting-for-risk-review
Collaborator
|
@dietmarw-se You may consider upstreaming your fix to qudt.org as well by opening a PR here: https://github.com/qudt/qudt-public-repo |
tfheen
added
risk-review-ongoing
|
Should the name also be correspondingly updated? |
Collaborator
The name looks correct to me, and aligned with the qudt.org definitions we base our catalog in. It's just the qudt.org symbol that is incorrect it seems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proper unit for reactive power is "var" already standardised in 1930 by the EEC (see also https://en.wikipedia.org/wiki/Volt-ampere#Reactive)
The QUDT points kind of to the correct unit but misinterprets the symbol in https://qudt.org/vocab/unit/VAR from its own source (https://cdd.iec.ch/cdd/iec62720/iec62720.nsf/Units/0112-2---62720%23UAB023)
To emphasis, the equivalent for "Apparent Power" is configured correctly to "VA" from https://qudt.org/vocab/unit/VA and https://cdd.iec.ch/cdd/iec62720/iec62720.nsf/Units/0112-2---62720%23UAA298 , respectively