Update testConversation.py#246
Merged
andrewrfreed merged 2 commits intomasterfrom Jan 25, 2024
Merged
Conversation
andrewrfreed
requested changes
Jan 25, 2024
Collaborator
andrewrfreed
left a comment
andrewrfreed
left a comment
There was a problem hiding this comment.
Good error fix, one suggestion to add a comment.
| elif 'generic' in resp['output'] and len(resp['output']['generic']) != 0: | ||
| elif 'generic' in resp['output'] and len(resp['output']['generic']) != 0 and 'text' in resp['output']['generic'][0]: | ||
| response_text_list = [ resp['output']['generic'][0]['text'] ] | ||
| elif 'generic' in resp['output'] and len(resp['output']['generic']) != 0 and 'title' in resp['output']['generic'][0]: |
Collaborator
There was a problem hiding this comment.
@victorpovar can you add a comment here in the code that this block is supporting disambiguation nodes?
Otherwise looks good to me and nice catch.
Collaborator
Author
There was a problem hiding this comment.
@andrewrfreed Done, added a comment. Thank you for the review.
Collaborator
Author
|
Added additional comment to add additional details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve issue #245
DCO 1.1 Signed-off-by: Victor Povar victorp@ca.ibm.com