Merged
Conversation
Separating construction and initialization is generally frowned upon in C++, and so the chapter isn't likely to be useful. The material that was there definitely isn't for the situations where separate construction and initialization is likely to be used. The material that would be relevant is covered already in other chapters, like the one on re-using buffers.
While the Rustonomicon does not provide side-by-side examples between C or C++ and Rust, the chapter does comprehensively discuss the concerns a C++ programmer would have about using the Rust FFI.
The chapter is mostly an index into other relevant materials, such as the Cargo book.
As it was it seemed like the chapter was going to be about applying those tools to Rust.
The chapters were either moved or removed.
The change was missed when renaming a file in a previous commit.
Two fixes: - Making `Any` a supertrait suffices, because trait upcasting was stabilized in 1.86. - It is the visitor that has to support downcasting, not the visited objects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added chapters on
Added quizzes to chapters on
Also fixed a typos in a few chapters.