Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix agent bug #658

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Fix agent bug #658

merged 1 commit into from
Aug 14, 2024

Conversation

BeatrixCohere
Copy link
Collaborator

@BeatrixCohere BeatrixCohere commented Aug 14, 2024

Thank you for contributing to the Cohere Toolkit!

  • PR title: "area: description"

    • Where "area" is whichever of interface, frontend, model, tools, backend, etc. is being modified. Use "docs: ..." for purely docs changes, "infra: ..." for CI changes.
    • Example: "deployment: add Azure model option"
  • PR message: Delete this entire checklist and replace with

    • Description: a description of the change
    • Issue: the issue # it fixes, if applicable
    • Dependencies: any dependencies required for this change
  • Add tests and docs: Please include testing and documentation for your changes

  • Lint and test: Run make lint and make run-tests

AI Description

The pull request makes changes to the src/backend/routers/conversation.py file, specifically to the generate_title async function.

Summary

The PR updates the agent_crud.get_agent_by_id function call to include the user_id parameter. This change ensures that the function retrieves the agent information based on both the agent_id and user_id.

Changes

  • Includes the user_id parameter in the agent_crud.get_agent_by_id function call.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.10%. Comparing base (86e1ce0) to head (513f66a).

Files Patch % Lines
src/backend/routers/conversation.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #658   +/-   ##
=======================================
  Coverage   77.10%   77.10%           
=======================================
  Files         238      238           
  Lines       10455    10455           
=======================================
  Hits         8061     8061           
  Misses       2394     2394           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeatrixCohere BeatrixCohere added this pull request to the merge queue Aug 14, 2024
Merged via the queue into main with commit e8d0ceb Aug 14, 2024
6 checks passed
@BeatrixCohere BeatrixCohere deleted the beatrix/Err branch August 14, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants