Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend: Add death loop detection #815

Merged
merged 2 commits into from
Oct 22, 2024
Merged

backend: Add death loop detection #815

merged 2 commits into from
Oct 22, 2024

Conversation

tianjing-li
Copy link
Collaborator

  • Imports Death loop from eno

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 84.94624% with 14 lines in your changes missing coverage. Please review.

Project coverage is 79.97%. Comparing base (f90aae1) to head (c12ee8f).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/backend/tests/unit/services/test_chat.py 80.00% 10 Missing ⚠️
src/backend/chat/custom/custom.py 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #815      +/-   ##
==========================================
+ Coverage   79.92%   79.97%   +0.04%     
==========================================
  Files         242      243       +1     
  Lines       10305    10395      +90     
==========================================
+ Hits         8236     8313      +77     
- Misses       2069     2082      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@EugeneLightsOn EugeneLightsOn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We need to re-sync it again after the Eno experiments are done.

@tianjing-li tianjing-li added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit ce5158b Oct 22, 2024
6 checks passed
@tianjing-li tianjing-li deleted the fix-death-loop branch October 22, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants