-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added Compound Finance Python Actions #248
base: main
Are you sure you want to change the base?
Conversation
🟡 Heimdall Review Status
|
b691818
to
80aadcb
Compare
Sample Conversation with Prototyped ReAct Agent. You can find the example code for this on a separate branch in my fork: https://github.com/mikeghen/agentkit/tree/compound-chatbot/python/examples/compound-finance-chatbot Wraps ETH to WETH
Supplies WETH to Compound
Borrows USDC from Compound
Gets Its Compound Portfolio Details
Repays USDC to Compound
Withdraws USDC from Compound
Unwraps WETH to ETH
|
@mikeghen PR generally LGTM! - Please fix breaking tests and we can merge. It looks like the integration test initialization is running in the GHA which is incorrect. |
8bf5115
to
67c2c05
Compare
Thanks for your review, @John-peterson-coinbase! I just made the change to fix the unit test failure, and this time I tested the actions on my fork on Github so verify they worked first. Let me know if you'd like to see anymore changes. |
Hey @mikeghen, thank you for your patience here. This PR looks amazing! We're releasing Python 0.1.0 very soon (targeting end of day today) which includes a new pattern for writing actions. Once that lands, let's rebase this PR and update the actions to the new pattern. Here's an example showcasing how we migrated the |
BTW @mikeghen great work on the integration test. I think it's reasonable to add a GitHub action with secrets configured in the repo settings. For this, we will need to update the test to accept either a JSON file, or API key name & secret which we can safely store in the repo settings. If you add the action and update the test, I can add the keys. If ok, let's use:
|
Thanks @0xRAG and @John-peterson-coinbase for your attention on this PR! Yes, I can revise my actions to use that new action provider pattern in v0.1.0. And, I can add the action as well for |
Hey @mikeghen the Python 0.1.0 release is out! Please reference the docs for instructions on creating actions in the new pattern, or reference an implementation Let me know how we can help. Looking forward to landing this soon! |
Also @mikeghen re: creating a GitHub action to run the integration tests: let's hold off on this for now. We're going to discuss the best approach for this. Definitely appreciate the addition of the integration tests! |
You're welcome @0xRAG, I'm glad to hear its getting addressed upstream. Thanks for following up on this. I have mostly refactored it for 0.1.0-python so I should have something for review again soon. |
67c2c05
to
9e53b4b
Compare
baa10f9
to
c055e90
Compare
@murrlincoln, @0xRAG, @John-peterson-coinbase, I was able to migrate to the new action provider design pattern and it's ready for another review. Let me know if there's anything you think I need to change. |
Adds Compound Finance actions get portfolio details, supply, borrow, repay, and withdraw. Includes unit and integration (with CDP) tests for the actions. Utility functions are added to make getting borrow, supply, and health details easily accessible.
c055e90
to
ffd4c0d
Compare
What changed? Why?
Adds Compound Finance actions get portfolio details, supply, borrow, repay, and withdraw. Includes unit and integration (with CDP) tests for the actions. Utility functions are added to make getting borrow, supply, and health details easily accessible.
Qualified Impact
Wrap and Unwrap ETH Action Changes
unwrap_eth
action.wrap/unwrap_eth
actions intoactions/weth
directory, created a constants file for weth.