Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat crewai - ETHGlobal #302

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

bilgin-kocak
Copy link

@bilgin-kocak bilgin-kocak commented Feb 8, 2025

#318

What changed? Why?

Qualified Impact

### What changed? Why?
Added CrewAI framework support to AgentKit, expanding the framework compatibility beyond just LangChain. This addition allows developers to use AgentKit actions with CrewAI's agent collaboration capabilities.

Key changes:

  • Added new cdp-crewai package that provides CrewAI integration
  • Implemented CrewAI toolkit with support for all CDP Agentkit core actions
  • Added wallet management and network support features
  • Added example chatbot implementation using CrewAI
  • This change expands AgentKit's framework support, making it more versatile for developers who prefer CrewAI's collaborative agent approach over LangChain's single-agent model.

Qualified Impact

Medium impact - adds new functionality without modifying existing code:

  1. New package addition only - no changes to existing packages like cdp-langchain or cdp-agentkit-core

  2. If issues arise:

  • The new CrewAI package can be unpublished without affecting other packages
  • Users can continue using the stable LangChain integration
  • Fixes can be deployed in new versions while maintaining backward compatibility
  1. Testing:
  • Unit tests added for CrewAI integration
  • End-to-end testing done using example chatbot
  • Follows same testing patterns used in LangChain integration

@cb-heimdall
Copy link

cb-heimdall commented Feb 8, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@bilgin-kocak bilgin-kocak changed the title Feat crewai Feat crewai - ETH Global Feb 8, 2025
@bilgin-kocak bilgin-kocak changed the title Feat crewai - ETH Global Feat crewai - ETHGlobal Feb 8, 2025
@0xRAG 0xRAG added needs review PR / issue needs review banana framework extension New framework extension labels Feb 10, 2025
@0xRAG
Copy link
Contributor

0xRAG commented Feb 11, 2025

Hey @bilgin-kocak thanks for the contribution, I took a quick glance and this is looking nice. Just FYI we are working on releasing v0.1.0 of the Python packages very soon which includes a structural update to the repo – specifically, framework extensions will live here: https://github.com/coinbase/agentkit/tree/0.1.0-python/python/framework-extensions

I'll ping you once the release is out so you can rebase and move the extension there!

@0xRAG 0xRAG added blocked and removed needs review PR / issue needs review labels Feb 11, 2025
@bilgin-kocak
Copy link
Author

bilgin-kocak commented Feb 12, 2025

@0xRAG Sure I will rebase it after structural updates

@0xRAG
Copy link
Contributor

0xRAG commented Feb 13, 2025

Hey @bilgin-kocak we just released Python v0.1.0, which includes a major change to how actions are structured! Please reference the docs for instructions on creating actions in the new pattern, or reference an implementation, then rebase your branch on main.

Let me know if you have any questions, thanks!

@0xRAG
Copy link
Contributor

0xRAG commented Feb 13, 2025

FYI in the new structure, the crew-ai extension integration would go under framework-extensions/crew-ai! Please reference framework-extensions/langchain for the correct pattern to use

@0xRAG 0xRAG added changes requested PR / Issue has changes requested python and removed blocked python labels Feb 13, 2025
@bilgin-kocak
Copy link
Author

Thanks I will do the updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
banana changes requested PR / Issue has changes requested framework extension New framework extension
Development

Successfully merging this pull request may close these issues.

3 participants