feat: viem signing hex or uint8array #388
Open
+10
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Allowed passing of a "hex" or bytes to "signMessage" for Viem & Viem-derived Wallet Providers
Why was this change implemented?
Currently Viem signing only supports strings. Viem itself can support Uint8Array & Hex (code, docs).
As the
evmWalletProvider
doesn't support the{ raw: <input> }
, we cast everything to a hex string based on the following logic and pass it into raw:This is to enable signing Hex messages as well as bytes (e.g. transaction hashes - this came up while trying to sign Gnosis Safe messages) - which otherwise get "hex'd" again by Viem when passed as string messages.
cc @escottalexander