Skip to content

fix: Correct benchmark function references, entropy seeds #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hsiuhsiu merged 1 commit into from
Dec 12, 2025
Merged

fix: Correct benchmark function references, entropy seeds #72

hsiuhsiu merged 1 commit into from
Dec 12, 2025
+28 −16

Conversation

@hsiuhsiu
Copy link
Contributor

@hsiuhsiu hsiuhsiu commented Dec 9, 2025

  • Fix BENCHMARK() macros to reference correct functions (BM_HMAC_SHA256, BM_AES_GCM_128, BM_AES_GCM_256) instead of wrong ones
  • Fix typo: BM_AEC_GCM -> BM_AES_GCM
  • Add benchmark::DoNotOptimize() to prevent compiler from optimizing out hash/encryption results
  • Use proper DRBG seeds with sufficient entropy (16 bytes) instead of short "test" string that doesn't meet SEC_P_COM requirement
  • Adjust benchmark input ranges for more meaningful measurements

@hsiuhsiu
fix: Correct benchmark function references, entropy seeds
506b075 
- Fix BENCHMARK() macros to reference correct functions (BM_HMAC_SHA256, BM_AES_GCM_128, BM_AES_GCM_256) instead of wrong ones
- Fix typo: BM_AEC_GCM -> BM_AES_GCM
- Add benchmark::DoNotOptimize() to prevent compiler from optimizing out hash/encryption results
- Use proper DRBG seeds with sufficient entropy (16 bytes) instead of short "test" string that doesn't meet SEC_P_COM requirement
- Adjust benchmark input ranges for more meaningful measurements
@cb-heimdall
Copy link

cb-heimdall commented Dec 9, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 2/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 2
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 1
Global minimum 0
Max 2
2
1 if commit is unverified 0
Sum 2
CODEOWNERS ✅ None for this change

@hsiuhsiu hsiuhsiu marked this pull request as ready for review December 9, 2025 15:25
valery-osheter-cb
valery-osheter-cb approved these changes Dec 11, 2025
View reviewed changes
Copy link

@valery-osheter-cb valery-osheter-cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@hsiuhsiu
Copy link
Contributor Author

hsiuhsiu commented Dec 12, 2025

  • Fix BENCHMARK() macros to reference correct functions (BM_HMAC_SHA256, BM_AES_GCM_128, BM_AES_GCM_256) instead of wrong ones
  • Fix typo: BM_AEC_GCM -> BM_AES_GCM
  • Add benchmark::DoNotOptimize() to prevent compiler from optimizing out hash/encryption results
  • Use proper DRBG seeds with sufficient entropy (16 bytes) instead of short "test" string that doesn't meet SEC_P_COM requirement
  • Adjust benchmark input ranges for more meaningful measurements

@hsiuhsiu hsiuhsiu merged commit 6493b1d into master Dec 12, 2025
8 checks passed
@hsiuhsiu hsiuhsiu deleted the fix-bm-hash branch December 12, 2025 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Arash-Afshar Arash-Afshar Arash-Afshar approved these changes

@valery-osheter-cb valery-osheter-cb valery-osheter-cb approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hsiuhsiu @cb-heimdall @Arash-Afshar @valery-osheter-cb