fix: quote argument-hint values starting with '[' in SKILL frontmatter#778
Open
thejesh23 wants to merge 1 commit into
Open
fix: quote argument-hint values starting with '[' in SKILL frontmatter#778thejesh23 wants to merge 1 commit into
thejesh23 wants to merge 1 commit into
Conversation
Unquoted values starting with '[' are parsed by YAML as flow sequences (arrays), not strings. Downstream tools such as GitHub Copilot CLI 1.0.65 require argument-hint to be a string and error out otherwise. Wrap the two affected values in quotes so YAML parses them as strings.
Collaborator
🟡 Heimdall Review Status
🟡
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
🟡
0/1
|
Denominator calculation
|
Author
|
Tracking issue: #779 — captures the bug diagnosis and reproducer separately for anyone searching the repo who lands there before this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Two
SKILL.mdfiles haveargument-hint:values whose first non-whitespace character is[. In YAML, an unquoted value starting with[is a flow sequence (array), not a string. This makes the frontmatter fail validation in tools that expectargument-hintto be a string.The most immediate example is GitHub Copilot CLI 1.0.65, which rejects the file with a schema error when
argument-hintparses as an array. The same latent issue has been reported against Claude Code (see anthropics/claude-code#22161).Fix: quote the two affected values so YAML parses them as strings.
Root cause (required for bugfixes)
YAML 1.2flow-style sequences begin with[. Any plain scalar whose first character is[is interpreted as the start of a flow sequence, not a string. Quoting the whole value forces string parsing regardless of the contents.Files changed:
.claude/skills/git.detect-breaking-changes/SKILL.mdargument-hint: [Number of commits to review]argument-hint: "[Number of commits to review]".claude/skills/research.component-libs/SKILL.mdargument-hint: [research goal (e.g. "theming architecture", ...)]argument-hint: '[research goal (e.g. "theming architecture", ...)]'(single-quoted because the value contains embedded double quotes)Other
SKILL.mdfiles in.claude/skills/were audited:deprecate-cds-api/SKILL.md,cds-migrator-transform/SKILL.md— already single-quoted strings. No change.components.styles/SKILL.md,components.write-docs/SKILL.md,git.backport/SKILL.md— start with<, which is a valid first character for a YAML plain scalar (parses as string). No change.UI changes
None. This change only affects the YAML frontmatter of two
.claude/skills/*/SKILL.mdfiles (developer-tooling metadata); no runtime code, no user-facing UI.Testing
How has it been tested?
Verified with a YAML parser that the
argument-hintfield now parses asstrrather thanlistin both files:Testing instructions
SKILL.mdfile in a YAML-schema-aware tool (e.g. GitHub Copilot CLI 1.0.65).argument-hintis treated as a string.Illustrations/Icons Checklist
Not applicable — no files under
packages/illustrations/**orpackages/icons/**are changed.Change management
type=routine
risk=low
impact=sev5
automerge=false
References
argument-hintYAML frontmatter with brackets causes React error #31 and unrecoverable TUI hang anthropics/claude-code#22161