Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Reference for Spend Permissions #89

Merged
merged 8 commits into from
Nov 8, 2024
Merged

API Reference for Spend Permissions #89

merged 8 commits into from
Nov 8, 2024

Conversation

amiecorso
Copy link
Contributor

@amiecorso amiecorso commented Nov 7, 2024 •
edited
Loading

A start on a more comprehensive set of API Reference pages for spend permissions.

@amiecorso amiecorso marked this pull request as ready for review November 7, 2024 16:32
@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Nov 7, 2024 •
edited
Loading

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@vercel Vercel
Copy link

vercel bot commented Nov 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
smart-wallet-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 7:48pm

ilikesymmetry
ilikesymmetry reviewed Nov 7, 2024
View reviewed changes
Copy link
Contributor

@ilikesymmetry ilikesymmetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting together!

docs/pages/guides/spend-permissions/api-reference.mdx Outdated Show resolved Hide resolved
docs/pages/guides/spend-permissions/api-reference.mdx Outdated Show resolved Hide resolved
docs/pages/guides/spend-permissions/api-reference.mdx Outdated Show resolved Hide resolved
docs/pages/guides/spend-permissions/api-reference.mdx Outdated Show resolved Hide resolved
docs/pages/guides/spend-permissions/api-reference.mdx Outdated Show resolved Hide resolved
docs/pages/guides/spend-permissions/api-reference.mdx Outdated Show resolved Hide resolved
docs/pages/guides/spend-permissions/api-reference.mdx Outdated Show resolved Hide resolved
docs/pages/guides/spend-permissions/api-reference.mdx Outdated Show resolved Hide resolved
docs/pages/guides/spend-permissions/api-reference.mdx Outdated Show resolved Hide resolved
docs/pages/guides/spend-permissions/api-reference.mdx Outdated Show resolved Hide resolved
spencerstock
spencerstock reviewed Nov 8, 2024
View reviewed changes
Copy link
Contributor

@spencerstock spencerstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is lovely

docs/pages/guides/spend-permissions/api-reference/client-resources.mdx Show resolved Hide resolved
docs/pages/guides/spend-permissions/api-reference/spendpermissionmanager.mdx Outdated Show resolved Hide resolved
docs/pages/guides/spend-permissions/api-reference/spendpermissionmanager.mdx Show resolved Hide resolved
docs/pages/guides/spend-permissions/api-reference/wallet-fetchpermissions.mdx Show resolved Hide resolved
@ilikesymmetry ilikesymmetry self-requested a review November 8, 2024 19:52
@cb-heimdall
Copy link
Collaborator

Review Error for ilikesymmetry @ 2024-11-08 19:52:25 UTC
User cannot review their own commit

@ilikesymmetry ilikesymmetry merged commit 53b6d5a into main Nov 8, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencerstock spencerstock spencerstock left review comments

@sluo10 sluo10 sluo10 left review comments

@ilikesymmetry ilikesymmetry ilikesymmetry approved these changes

@lukasrosario lukasrosario Awaiting requested review from lukasrosario

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amiecorso @cb-heimdall @sluo10 @ilikesymmetry @spencerstock