Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note for strict ordering #98

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Note for strict ordering #98

merged 1 commit into from
Nov 15, 2024

Conversation

spencerstock
Copy link
Contributor

@spencerstock spencerstock commented Nov 15, 2024

Added a small note for ordering of paramters for spend permissions
Screenshot 2024-11-15 at 11 32 43 AM

Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
smart-wallet-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 9:34pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Nov 15, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@spencerstock spencerstock changed the title add note for strict ordering Note for strict ordering Nov 15, 2024
amiecorso
amiecorso previously approved these changes Nov 15, 2024
@cb-heimdall cb-heimdall dismissed amiecorso’s stale review November 15, 2024 21:33

Approved review 2439656348 from amiecorso is now dismissed due to new commit. Re-request for approval.

@amiecorso amiecorso self-requested a review November 15, 2024 21:47
@spencerstock spencerstock merged commit 0d70a76 into main Nov 15, 2024
6 checks passed
@spencerstock spencerstock deleted the spencer/note branch November 15, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants