Support ARM64 platform #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irisyann
force-pushed
the
devin/1724234741-add-arm64-support
branch
from
a6550cd to
aecd1a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated by Devin. Manually patched because Devin doesn't have access to this repository.
This fix is needed because
wkhtmltoimage-binarygem doesn't support ARM64 architecture. Recently our workers were upgraded to use Ubuntu 24.04 ARM64 architecture. This is causingimgkitto fail at generating social images for coins and categories because under the hood,imgkitgem useswkhtmltoimage-binarygem.Modify platform detection logic in wkhtmltoimage to add ARM64 support (aarch64-linux → 'aarch64', arm64-darwin → fallback to 'darwin-x64' for Rosetta)
Add 43MB ARM64 binary wkhtmltoimage-aarch64 to libexec/ directory (extracted from official wkhtmltopdf 0.12.6.1 release)