Lock whole delete loop to prevent concurrent access

coinpaprika · Mar 21, 2019 · b909143 · b909143
1 parent 90506ef
commit b909143
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/map_limit_store.go b/map_limit_store.go
@@ -27,13 +27,13 @@ func NewMapLimitStore(expirationTime time.Duration, flushInterval time.Duration)
 	go func() {
 		ticker := time.NewTicker(flushInterval)
 		for range ticker.C {
+			m.mutex.Lock()
 			for key, val := range m.data {
 				if val.lastUpdate.Before(time.Now().UTC().Add(-m.expirationTime)) {
-					m.mutex.Lock()
 					delete(m.data, key)
-					m.mutex.Unlock()
 				}
 			}
+			m.mutex.Unlock()
 		}
 	}()
 	return m