Merge pull request #3 from oskarwojciski/search_by_symbol

Search by symbol
coinpaprika · Dec 27, 2018 · 588ab9a · 588ab9a
2 parents b175452 + 3135f27
commit 588ab9a
Show file tree

Hide file tree

Showing 11 changed files with 354 additions and 58 deletions.
diff --git a/Gopkg.lock b/Gopkg.lock
diff --git a/cmd/run.go b/cmd/run.go
@@ -191,15 +191,25 @@ func commandVolume(argument string) (string, error) {
 func getTickerByQuery(query string) (*coinpaprika.Ticker, error) {
 	paprikaClient := coinpaprika.NewClient(nil)
 
-	searchOpts := &coinpaprika.SearchOptions{Query: query, Categories: "currencies"}
+	searchOpts := &coinpaprika.SearchOptions{Query: query, Categories: "currencies", Modifier: "symbol_search"}
 	result, err := paprikaClient.Search.Search(searchOpts)
 	if err != nil {
 		return nil, errors.Wrap(err, "query:"+query)
 	}
 
-	log.Debugf("found %d results for query :%s", len(result.Currencies), query)
+	log.Debugf("found %d results for query by symbol :%s", len(result.Currencies), query)
 	if len(result.Currencies) <= 0 {
-		return nil, errors.Errorf("invalid coin name|ticker|symbol")
+		//search by name:
+		searchOpts = &coinpaprika.SearchOptions{Query: query, Categories: "currencies"}
+		result, err = paprikaClient.Search.Search(searchOpts)
+		if err != nil {
+			return nil, errors.Wrap(err, "query:"+query)
+		}
+		log.Debugf("found %d results for query by name :%s", len(result.Currencies), query)
+
+		if len(result.Currencies) <= 0 {
+			return nil, errors.Errorf("invalid coin name|ticker|symbol")
+		}
 	}
 	if result.Currencies[0].ID == nil {
 		return nil, errors.New("missing id for a coin")

diff --git a/cmd/run_test.go b/cmd/run_test.go
@@ -39,6 +39,8 @@ func (suite *RunTestSuite) TestCommandPrice() {
 
 		if !r.error {
 			suite.NoError(err)
+		} else {
+			suite.Error(err)
 		}
 
 		if r.contains != "" {
@@ -75,6 +77,8 @@ func (suite *RunTestSuite) TestCommandSupply() {
 			supplyInt, err := strconv.Atoi(supplyStrings[0])
 			suite.NoError(err)
 			suite.True(supplyInt > 100, "should be more than 100")
+		} else {
+			suite.Error(err)
 		}
 	}
 }
@@ -107,6 +111,8 @@ func (suite *RunTestSuite) TestCommandVolume() {
 			volumeFloat, err := strconv.ParseFloat(volumeStrings[0], 64)
 			suite.NoError(err)
 			suite.True(volumeFloat > 100, "should be more than 100")
+		} else {
+			suite.Error(err)
 		}
 	}
 }

diff --git a/vendor/github.com/coinpaprika/coinpaprika-api-go-client/coinpaprika/client.go b/vendor/github.com/coinpaprika/coinpaprika-api-go-client/coinpaprika/client.go