Add .env file and update Google client ID

coji · Jan 18, 2024 · d98fc37 · d98fc37
1 parent 3b2b12b
commit d98fc37
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 4 deletions.
diff --git a/.env.example b/.env.example
@@ -0,0 +1,2 @@
+VITE_GOOGLE_CLIENT_ID=your_google_client_id
+
diff --git a/.github/workflows/firebase-hosting-merge.yml b/.github/workflows/firebase-hosting-merge.yml
@@ -11,6 +11,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
+      - name: create .env file
+        run: |
+          echo "VITE_GOOGLE_CLIENT_ID=${{ secrets.VITE_GOOGLE_CLIENT_ID }}" >> .env
       - uses: pnpm/[email protected]
         name: Install pnpm
         id: pnpm-install

diff --git a/.github/workflows/firebase-hosting-pull-request.yml b/.github/workflows/firebase-hosting-pull-request.yml
@@ -9,6 +9,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
+      - name: create .env file
+        run: |
+          echo "VITE_GOOGLE_CLIENT_ID=${{ secrets.VITE_GOOGLE_CLIENT_ID }}" >> .env
       - uses: pnpm/[email protected]
         name: Install pnpm
         id: pnpm-install

diff --git a/app/libs/google-auth.ts b/app/libs/google-auth.ts
@@ -15,7 +15,6 @@ export const createGoogleAuthenticator = ({
   ],
 }: {
   clientID: string
-  clientSecret: string
   callbackURL: string
   accessType?: 'online' | 'offline'
   includeGrantedScopes?: boolean

diff --git a/app/services/google-auth.ts b/app/services/google-auth.ts
@@ -1,9 +1,7 @@
 import { createGoogleAuthenticator } from '~/libs/google-auth'
 
 const googleAuthenticator = createGoogleAuthenticator({
-  clientID:
-    '555137498198-910lfdq60rjkclt8hbut5bhe0esfv4vn.apps.googleusercontent.com',
-  clientSecret: import.meta.env.GOOGLE_CLIENT_SECRET,
+  clientID: import.meta.env.VITE_GOOGLE_CLIENT_ID,
   callbackURL: '/auth/google/callback',
 })
 const authenticate = googleAuthenticator.authenticate