Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Protect against prototype poisoning #87

Merged
merged 1 commit into from
Jun 5, 2024
Merged

feat: Protect against prototype poisoning #87

merged 1 commit into from
Jun 5, 2024

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Jun 5, 2024 •
edited
Loading

follow fastify/fastify#1427

throw SyntaxError when prototype poisoning happen by default

closes #70

@fengmk2
feat: Protect against prototype poisoning
3db8dd0 
follow fastify/fastify#1427

throw SyntaxError when prototype poisoning happen by default
killagu
killagu approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengmk2 fengmk2 mentioned this pull request Jun 5, 2024
Closed
@fengmk2
Copy link
Member Author

fengmk2 commented Jun 5, 2024

expressjs/body-parser#347

@fengmk2
Copy link
Member Author

fengmk2 commented Jun 5, 2024

performance expressjs/body-parser#347 (comment)

JSON.parse(): 476,018 ops/sec
Bourne.parse(): 458,014 ops/sec
JSON.parse() followed by Bourne.scan(): 380,877 ops/sec
JSON.parse() with reviver: 183,411 ops/sec

@fengmk2 fengmk2 merged commit 2bc63a5 into master Jun 5, 2024
9 checks passed
@fengmk2 fengmk2 deleted the protect-prototype-poisoning branch June 5, 2024 07:58
fengmk2 added a commit to eggjs/egg that referenced this pull request Jun 7, 2024
@fengmk2
feat: add bodyParser.onProtoPoisoning type define
e539699 
cojs/co-body#87
@fengmk2 fengmk2 mentioned this pull request Jun 7, 2024
Merged
fengmk2 added a commit to eggjs/egg that referenced this pull request Jun 7, 2024
@fengmk2
feat: add bodyParser.onProtoPoisoning type define (#5324)
b3582e0 
cojs/co-body#87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killagu killagu killagu approved these changes

Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Protect against prototype poisoning
2 participants
@fengmk2 @killagu