Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch implicit make flags to use GNUMAKEFLAGS var #145

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Switch implicit make flags to use GNUMAKEFLAGS var #145

wants to merge 1 commit into from

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Nov 21, 2024

There are a few notable elements addressed by this change:

  1. The --load/-l argument is GNU-only and doesn't work on BSD make
  2. The GNUMAKEFLAGS environment variable was previously ignored when looking for existing make arguments
  3. By passing the flags via command line arguments to CMake's build invocation, the makeflags were sometimes omitted due to incompatibility.

Until I can come up with some tests for this, I'll keep this PR in draft.

@cottsay
Switch implicit make flags to use GNUMAKEFLAGS var
0b46f2a 
There are a few notable elements addressed by this change:
1. The --load/-l argument is GNU-only and doesn't work on BSD make
2. The GNUMAKEFLAGS environment variable was previously ignored when
   looking for existing make arguments
3. By passing the flags via command line arguments to CMake's build
   invocation, the makeflags were sometimes omitted due to
   incompatibility.
@cottsay cottsay self-assigned this Nov 21, 2024
nuclearsandwich
nuclearsandwich reviewed Nov 22, 2024
View reviewed changes
Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review looks reasonable. The inversion of get -> set means that we lose an internal API surface to check these values for downstream processes but I have a feeling that we'll come up with better internal APIs when we have a use case to drive them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuclearsandwich nuclearsandwich nuclearsandwich left review comments

Assignees

@cottsay cottsay

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cottsay @nuclearsandwich