Add support for Android compressed rel/rela sections #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hxzhao527
commented
Aug 22, 2024
•
hxzhao527
commented
- APS2
- RELR
hxzhao527
changed the title
hxzhao527
force-pushed
the
feature/android_relocation
branch
3 times, most recently
from
9769970 to
17036f2
Compare
hxzhao527
changed the title
hxzhao527
force-pushed
the
feature/android_relocation
branch
from
17036f2 to
c02757b
Compare
|
@cole14 could you review this? thanks |
|
Thanks for the PR! I can probably take a deeper look some time in the next few days |
hxzhao527
commented
Aug 28, 2024
| } | ||
|
|
||
| impl<'data> Iterator for ParsingIterator<'data, false> { | ||
| type Item = Result<Rel, ParseError>; |
There was a problem hiding this comment.
here, a different return value style from other iterators in the project.
when &[8] got unexpected eof, parsing .rel got rela and etc will get Err(...)
1. `APS2` 2. `RELR`
hxzhao527
force-pushed
the
feature/android_relocation
branch
from
c02757b to
27e7827
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.