Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly convert to dataframe and return the df #120

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Properly convert to dataframe and return the df #120

wants to merge 6 commits into from

Commits on Mar 6, 2019

  1. Properly convert to dataframe and return the df 

    Used as.data.frame(x) instead of data.frame(x) to handle conversion of tibbles (and other sort of rectangular data).
Then at the end of the function added x to the invisible() command, so the actual data could be returned and used in a pipe.
    @IdoBar
    IdoBar authored Mar 6, 2019
    Configuration menu
    Copy the full SHA
    db018c1 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2019

  1. Check if data is a tibble in write.xlsx() 

    Check if data is a data.frame OR is a tibble() to convert for a data.frame before writing.
    @IdoBar
    IdoBar authored Mar 9, 2019
    Configuration menu
    Copy the full SHA
    ee59cc1 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2020

  1. Merge remote-tracking branch 'origin/master' into IdoBar-patch-1

    @colearendt
    colearendt committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    b9e2f9a View commit details
    Browse the repository at this point in the history

  2. protect against coercing strings to factors

    @colearendt
    colearendt committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    7124159 View commit details
    Browse the repository at this point in the history

  3. add a slew of tests

    @colearendt
    colearendt committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    48cacff View commit details
    Browse the repository at this point in the history

  4. add some more tests

    @colearendt
    colearendt committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    1f5dbd6 View commit details
    Browse the repository at this point in the history